Fix test case in TestCreateExpectedEventPatterns

[creydr]

TestCreateExpectedEventPatterns will start to fail with go 1.22 (see #8019 (comment)):

$ go test ./test/rekt/features/broker/... -run TestCreateExpectedEventPatterns
ok      knative.dev/eventing/test/rekt/features/broker  0.015s

$ GOEXPERIMENT=loopvar go test ./test/rekt/features/broker/... -run TestCreateExpectedEventPatterns
--- FAIL: TestCreateExpectedEventPatterns (0.00s)
    --- FAIL: TestCreateExpectedEventPatterns/t1,_one_retry,_one_failure,_both_t0_/_t1_get_it,_t1dlq_gets_it_too (0.00s)
        topology_test.go:227: t1, one retry, one failure, both t0 / t1 get it, t1dlq gets it too: Maps unequal: want:
            map[brokerdlq:{Success:[] Interval:[]} t0:{Success:[true] Interval:[0]} t0dlq:{Success:[] Interval:[]} t1:{Success:[false true] Interval:[0 0]} t1dlq:{Success:[true] Interval:[0]}]
            got:
            map[brokerdlq:{Success:[] Interval:[]} t0:{Success:[true] Interval:[0]} t0dlq:{Success:[] Interval:[]} t1:{Success:[false true] Interval:[0 0]} t1dlq:{Success:[] Interval:[]}]
FAIL
FAIL    knative.dev/eventing/test/rekt/features/broker  0.016s
FAIL

The test was actually never totally correct and only the last test case was tested. See https://go.dev/blog/loopvar-preview:

In Go 1.21, ... passes because t.Parallel blocks each subtest until the entire loop has finished and then runs all the subtests in parallel.

This PR addresses it and fixes the test. Actually the tests is the same as the one for t0 which was setup correctly:

eventing/test/rekt/features/broker/topology_test.go

Lines 101 to 122 in 67958c6

	name: "t0, one retry, one failure, both t0 / t1 get it, t0dlq gets it too",
	brokerDS: nil,
	t0DS: &v1.DeliverySpec{
	Retry: ptr.Int32(1),
	DeadLetterSink: new(pkgduckv1.Destination),
	},
	t1DS: nil,
	t0FailCount: 2,
	t1FailCount: 0,
	want: map[string]knconf.EventPattern{
	"t0": {
	Success: []bool{false, false},
	Interval: []uint{0, 0},
	},
	"t1": {
	Success: []bool{true},
	Interval: []uint{0},
	},
	"t0dlq": oneSuccessfulEvent,
	"t1dlq": noEvents,
	"brokerdlq": noEvents,
	},

[creydr]

/cc @pierDipi

[dprotaso]

/lgtm
/approve

[knative-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• test/OWNERS [creydr,dprotaso]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment