Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test case in TestCreateExpectedEventDeliveryMap #8023

Conversation

creydr
Copy link
Member

@creydr creydr commented Jun 24, 2024

Similar to #8022 fixing an error in a unit test (TestCreateExpectedEventDeliveryMap)

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 24, 2024
@knative-prow knative-prow bot added the area/test-and-release Test infrastructure, tests or release label Jun 24, 2024
@creydr
Copy link
Member Author

creydr commented Jun 24, 2024

/cc @pierDipi @dprotaso

Copy link

codecov bot commented Jun 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.79%. Comparing base (825202f) to head (666eab9).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8023   +/-   ##
=======================================
  Coverage   67.79%   67.79%           
=======================================
  Files         363      363           
  Lines       16899    16899           
=======================================
  Hits        11456    11456           
  Misses       4735     4735           
  Partials      708      708           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jun 24, 2024
Copy link

knative-prow bot commented Jun 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 36c904a into knative:main Jun 24, 2024
28 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants