Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating links to docs repo #954

Merged
merged 1 commit into from
Mar 22, 2019
Merged

Updating links to docs repo #954

merged 1 commit into from
Mar 22, 2019

Conversation

samodell
Copy link
Contributor

Work towards fixing knative/docs#1038

Proposed Changes

  • Updates all links in the Eventing repo that began with github.com/knative/docs
  • Most links updated to point to the content on knative.dev, but kept the link to the samples pointing to the new location of the samples folder on Github

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Mar 22, 2019
@knative-prow-robot knative-prow-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 22, 2019
@samodell samodell mentioned this pull request Mar 22, 2019
Closed
7 tasks
evankanderson
evankanderson reviewed Mar 22, 2019
View reviewed changes
Copy link
Member

@evankanderson evankanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 22, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: evankanderson, samodell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 22, 2019
@knative-prow-robot knative-prow-robot merged commit 1d22e95 into knative:master Mar 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evankanderson evankanderson evankanderson left review comments

@grantr grantr Awaiting requested review from grantr

@n3wscott n3wscott Awaiting requested review from n3wscott

Assignees

@evankanderson evankanderson

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@samodell @knative-prow-robot @evankanderson @googlebot