Fix failing concurrent test on Windows

[matejvasek]

Changes

• 🐛 Fix filing tests on Windows related to incorrect process livenes detection.
• 🧹 Change symlink from being absolute to being relative.
• 🧹 Better test output + the test does not hang on Windows.

[knative-prow]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[codecov]

Codecov Report

Patch coverage: 62.50% and project coverage change: +0.83% 🎉

Comparison is base (a2834c2) 61.95% compared to head (9d9c06c) 62.79%.
Report is 3 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1890      +/-   ##
==========================================
+ Coverage   61.95%   62.79%   +0.83%     
==========================================
  Files         106      107       +1     
  Lines       13801    13811      +10     
==========================================
+ Hits         8551     8673     +122     
+ Misses       4397     4260     -137     
- Partials      853      878      +25     

Flag	Coverage Δ
e2e-test	35.50% <0.00%> (-0.03%)	⬇️
e2e-test-oncluster	30.82% <0.00%> (+0.11%)	⬆️
e2e-test-oncluster-runtime	25.64% <0.00%> (?)
e2e-test-runtime-node	26.93% <0.00%> (?)
e2e-test-runtime-python	26.93% <0.00%> (?)
e2e-test-runtime-quarkus	27.05% <0.00%> (?)
e2e-test-runtime-typescript	27.05% <0.00%> (?)
integration-tests	51.43% <25.00%> (+2.16%)	⬆️
unit-tests-macos-latest	48.66% <25.00%> (-0.56%)	⬇️
unit-tests-ubuntu-latest	?
unit-tests-windows-latest	48.70% <62.50%> (-0.61%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
pkg/oci/builder.go	63.79% <62.50%> (-13.46%)	⬇️

... and 13 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[matejvasek]

@lkingland PTAL

[matejvasek]

=== RUN   TestBuilder_Concurrency
mkdir -p C:\Users\mvasek\AppData\Local\Temp\TestBuilder_Concurrency3717259113\001\.func\builds\by-hash\8cf6addafdcbc49
5ab800c0a8210f7ca4c486ee17f5cac9cc8be10ed51f7a3f3
mkdir -p C:\Users\mvasek\AppData\Local\Temp\TestBuilder_Concurrency3717259113\001\.func\builds\by-pid
ln -s ..\by-hash\8cf6addafdcbc495ab800c0a8210f7ca4c486ee17f5cac9cc8be10ed51f7a3f3 C:\Users\mvasek\AppData\Local\Temp\T
estBuilder_Concurrency3717259113\001\.func\builds\by-pid\23056
→ /func 
→ /func/README.md
→ /func/func.yaml
→ /func/go.mod
→ /func/handle.go
→ /func/handle_test.go
mv .\datalayer.tar.gz .\oci\blobs\sha256\17d96d33daa25c79f1086a5d848c8cdceba9e590721c70c48e45176fb1c018ab
→ /etc/ssl/certs/ca-certificates.crt
→ /etc/pki/tls/certs/ca-certificates.crt
mv .\certslayer.tar.gz .\oci\blobs\sha256\6d9104c57ada84f79fdaf1ee171d35c60a98c576776dbe5d409153bbd172310d
rm -rf C:\Users\mvasek\AppData\Local\Temp\TestBuilder_Concurrency3717259113\001\.func\builds\by-hash\8cf6addafdcbc495a
b800c0a8210f7ca4c486ee17f5cac9cc8be10ed51f7a3f3
    builder_test.go:118: test build error: remove C:\Users\mvasek\AppData\Local\Temp\TestBuilder_Concurrency3717259113
\001\.func\builds\by-hash\8cf6addafdcbc495ab800c0a8210f7ca4c486ee17f5cac9cc8be10ed51f7a3f3\config.json: The process ca
nnot access the file because it is being used by another process.
mv .\config.json .\oci\blobs\sha256\979f5a8533d239b98f596c2333c02d8ae75568b93f227e71fdf89954e034c745
rm C:\Users\mvasek\AppData\Local\Temp\TestBuilder_Concurrency3717259113\001\.func\builds\by-pid\23056
rm C:\Users\mvasek\AppData\Local\Temp\TestBuilder_Concurrency3717259113\001\.func\builds\by-hash\8cf6addafdcbc495ab800
c0a8210f7ca4c486ee17f5cac9cc8be10ed51f7a3f3
    builder_test.go:101: test build error: rename C:\Users\mvasek\AppData\Local\Temp\TestBuilder_Concurrency3717259113
\001\.func\builds\by-hash\8cf6addafdcbc495ab800c0a8210f7ca4c486ee17f5cac9cc8be10ed51f7a3f3\config.json C:\Users\mvasek
\AppData\Local\Temp\TestBuilder_Concurrency3717259113\001\.func\builds\by-hash\8cf6addafdcbc495ab800c0a8210f7ca4c486ee
17f5cac9cc8be10ed51f7a3f3\oci\blobs\sha256\979f5a8533d239b98f596c2333c02d8ae75568b93f227e71fdf89954e034c745: The syste
m cannot find the path specified.
--- FAIL: TestBuilder_Concurrency (0.09s)
FAIL

This is the error I am getting on my Windows machine now. Previously the test just hanged till timeout.

[lkingland]

This looks like a legitimate bug to me; it appears the test was exiting when a single builder returned on the done channel, rather than waiting for both
/lgtm !

[matejvasek]

@lance please override the failing test.

[matejvasek]

@lance PTAL

[matejvasek]

@lkingland PTAL

[knative-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lkingland, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [lkingland,matejvasek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment