[release-1.11] backports for release-1.11.1 #1998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matej Vasek <mvasek@redhat.com>
Signed-off-by: Matej Vasek <mvasek@redhat.com>
Without this change prow test will refer tkn yamls from the main branch not from the PR head branch. Signed-off-by: Matej Vasek <mvasek@redhat.com>
|
@matejvasek: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Skipping CI for Draft Pull Request. |
knative-prow
bot
added
the
do-not-merge/work-in-progress
knative-prow
bot
added
the
approved
knative-prow-robot
added
the
needs-rebase
knative-prow
bot
added
the
size/M
knative-prow-robot
removed
the
needs-rebase
* Minimize release binary size. * Release latest version of buildpack tekton task. Signed-off-by: Matej Vasek <mvasek@redhat.com>
matejvasek
force-pushed
the
rel-1.11.1
branch
from
6deb00d
to
a7f9995
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## release-1.11 #1998 +/- ##
================================================
+ Coverage 61.98% 62.77% +0.78%
================================================
Files 107 107
Lines 13804 13833 +29
================================================
+ Hits 8557 8684 +127
+ Misses 4397 4269 -128
- Partials 850 880 +30
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
knative-prow
bot
added
size/XL
…var for e2e oncluter tests (knative#1963)
Our image is much more recent and it is multiarch. Signed-off-by: Matej Vasek <mvasek@redhat.com>
Signed-off-by: Matej Vasek <mvasek@redhat.com>
Signed-off-by: Matej Vasek <mvasek@redhat.com>
Co-authored-by: Knative Automation <automation@knative.team> Signed-off-by: Matej Vasek <mvasek@redhat.com>
Signed-off-by: Matej Vasek <mvasek@redhat.com>
Signed-off-by: Matej Vasek <mvasek@redhat.com>
Signed-off-by: Matej Vasek <mvasek@redhat.com>
* fix: docker registry/repository parsing Use go-containerregistry to do parsing. Signed-off-by: Matej Vasek <mvasek@redhat.com> * fix: use kebab-case instead of camelCase Signed-off-by: Matej Vasek <mvasek@redhat.com> * fix: use kebab-case instead of camelCase Signed-off-by: Matej Vasek <mvasek@redhat.com> --------- Signed-off-by: Matej Vasek <mvasek@redhat.com>
* src: better debugging Signed-off-by: Matej Vasek <mvasek@redhat.com> * fix: wait for both builds Signed-off-by: Matej Vasek <mvasek@redhat.com> * fixup Signed-off-by: Matej Vasek <mvasek@redhat.com> * fixup Signed-off-by: Matej Vasek <mvasek@redhat.com> * fixup Signed-off-by: Matej Vasek <mvasek@redhat.com> * fix: detection of process liveness on Windows Signed-off-by: Matej Vasek <mvasek@redhat.com> * fix: make symlink relative Signed-off-by: Matej Vasek <mvasek@redhat.com> * fixup: cleanup Signed-off-by: Matej Vasek <mvasek@redhat.com> --------- Signed-off-by: Matej Vasek <mvasek@redhat.com>
matejvasek
force-pushed
the
rel-1.11.1
branch
from
29944ca
to
3742481
Compare
knative-prow
bot
added
size/XXL
* chore: use custom jammy paketo builder Use our own modified jammy builder with additional buildpacks for GoFunc and Rust. This enables on cluster build for Go and Rust functions. Where possible (Go, Java) we use "tiny" variant, other runtimes use "base" variant. The updated task is new file instead of modifying existing task this is done for sake of keeping compatiblility. Signed-off-by: Matej Vasek <mvasek@redhat.com> * fixup: remove unnecessary code per review request Signed-off-by: Matej Vasek <mvasek@redhat.com> * fixup Signed-off-by: Matej Vasek <mvasek@redhat.com> * fixup: podman test refers correct tkn task yamls Signed-off-by: Matej Vasek <mvasek@redhat.com> --------- Signed-off-by: Matej Vasek <mvasek@redhat.com>
* doc: Go and Rust on cluster build is supported Signed-off-by: Matej Vasek <mvasek@redhat.com> * doc: build envvars Signed-off-by: Matej Vasek <mvasek@redhat.com> --------- Signed-off-by: Matej Vasek <mvasek@redhat.com>
Signed-off-by: Matej Vasek <mvasek@redhat.com>
Signed-off-by: Matej Vasek <mvasek@redhat.com>
Signed-off-by: Matej Vasek <mvasek@redhat.com>
matejvasek
force-pushed
the
rel-1.11.1
branch
from
5dfb13f
to
347fe51
Compare
matejvasek
requested review from
jrangelramos,
gauron99,
lkingland and
krsna-m
and removed request for
rhuss and
vyasgun
matejvasek
changed the title
|
/ok-to-test |
knative-prow
bot
added
the
ok-to-test
knative-prow
bot
removed
the
do-not-merge/work-in-progress
lkingland
approved these changes
Oct 2, 2023
Comment on lines
-570
to
-580
| registryTokens := strings.Split(f.Registry, "/") | ||
| if len(registryTokens) == 1 { // only namespace provided: ex. 'alice' | ||
| image = DefaultRegistry + "/" + f.Registry + "/" + f.Name | ||
| } else if len(registryTokens) == 2 || len(registryTokens) == 3 { | ||
| // registry/namespace ('quay.io/alice') or | ||
| // registry/parent-namespace/namespace ('quay.io/project/alice') provided | ||
| image = f.Registry + "/" + f.Name | ||
| } else if len(registryTokens) > 3 { // the name of the image is also provided `quay.io/alice/my.function.name` | ||
| return "", fmt.Errorf("registry should be either 'namespace', 'registry/namespace' or 'registry/parent/namespace', the name of the image will be derived from the function name") | ||
| } | ||
|
|
Comment on lines
+239
to
+241
| if runtime.GOOS == "windows" { | ||
| return true | ||
| } |
There was a problem hiding this comment.
I like the effect; a shame it requires an if windows! A comment on why this exists will help future supporters who are not aware of why this was necessary :/ I can add that on a future PR though.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lkingland, matejvasek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixed parsing of image repositories with more complex hierarchy (sub-paths). Example of such registry:
us-central1-docker.pkg.dev/my-gcpproject/team/user.Fixed possible infinite hang on Windows with
"host"builder.Fixed issue where on cluster build fails because of insufficient permissions on some clusters.
Enabled
buildpackon-cluster-build for Go and Rust.Enabled
s2ion-cluster-build onaarch64,ppc64leands390xclusters.Updated
buildahimage reference ins2itekton task.Updated Quarkus version in templates.
Updated Spring Boot version in templates.