Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Go and Rust on cluster build is supported #1923

Merged
merged 2 commits into from
Aug 12, 2023

Conversation

matejvasek
Copy link
Contributor

Changes

Update doc: Go and Rust on cluster build is supported.

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 10, 2023
@matejvasek matejvasek requested review from gauron99, jrangelramos and lkingland and removed request for rhuss and navidshaikh August 10, 2023 13:53
@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.92% 🎉

Comparison is base (efb04be) 61.85% compared to head (b99508f) 62.78%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1923      +/-   ##
==========================================
+ Coverage   61.85%   62.78%   +0.92%     
==========================================
  Files         107      107              
  Lines       13813    13814       +1     
==========================================
+ Hits         8544     8673     +129     
+ Misses       4415     4262     -153     
- Partials      854      879      +25     
Flag Coverage Δ
e2e-test 35.49% <ø> (+0.08%) ⬆️
e2e-test-oncluster 30.71% <ø> (-0.12%) ⬇️
e2e-test-oncluster-runtime 25.65% <ø> (?)
e2e-test-runtime-go 25.84% <ø> (?)
e2e-test-runtime-node 26.93% <ø> (?)
e2e-test-runtime-python 26.93% <ø> (?)
e2e-test-runtime-quarkus 27.04% <ø> (?)
e2e-test-runtime-rust 25.93% <ø> (?)
e2e-test-runtime-springboot 26.07% <ø> (?)
e2e-test-runtime-typescript 27.04% <ø> (?)
integration-tests 51.44% <ø> (+2.12%) ⬆️
unit-tests-macos-latest 48.28% <ø> (+0.02%) ⬆️
unit-tests-ubuntu-latest 49.07% <ø> (+<0.01%) ⬆️
unit-tests-windows-latest 48.32% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matejvasek
Copy link
Contributor Author

PTAL @jrangelramos

@Shashankft9
Copy link
Member

this can be removed, since its not relevant anymore:

# builderImages: # optional, needed only if the runtime is golang
# pack: ghcr.io/boson-project/go-function-builder:tip
buildpacks: []
builder: ""
buildEnvs: []

@Shashankft9
Copy link
Member

would it make sense to add some documentation around why we are using knative custom jammy builders instead of paketo base?
And maybe in the func development guide to make use of those two env variables if the tekton tasks are changed?

Signed-off-by: Matej Vasek <mvasek@redhat.com>
@matejvasek
Copy link
Contributor Author

would it make sense to add some documentation around why we are using knative custom jammy builders instead of paketo base? And maybe in the func development guide to make use of those two env variables if the tekton tasks are changed?

Jammy is now the paketo builder. The previous one has been deprecated.

@matejvasek
Copy link
Contributor Author

And maybe in the func development guide to make use of those two env variables if the tekton tasks are changed?

What do you mean? @Shashankft9

@matejvasek
Copy link
Contributor Author

matejvasek commented Aug 10, 2023

would it make sense to add some documentation around why we are using knative custom jammy builders instead of paketo base? And maybe in the func development guide to make use of those two env variables if the tekton tasks are changed?

Jammy is now the paketo builder. The previous one has been deprecated.

What I mean is https://github.com/paketo-buildpacks/base-builder says:

This repository has been archived by the owner on Jul 20, 2023. It is now read-only.

@matejvasek
Copy link
Contributor Author

I don't think we need to justify our builder IMO.

@matejvasek
Copy link
Contributor Author

PTAL @jrangelramos

Signed-off-by: Matej Vasek <mvasek@redhat.com>
@matejvasek
Copy link
Contributor Author

PTAL @Shashankft9

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 12, 2023
@knative-prow
Copy link

knative-prow bot commented Aug 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matejvasek, Shashankft9

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit b98bb9b into knative:main Aug 12, 2023
34 checks passed
matejvasek added a commit to matejvasek/faas that referenced this pull request Sep 27, 2023
* doc: Go and Rust on cluster build is supported

Signed-off-by: Matej Vasek <mvasek@redhat.com>

* doc: build envvars

Signed-off-by: Matej Vasek <mvasek@redhat.com>

---------

Signed-off-by: Matej Vasek <mvasek@redhat.com>
matejvasek added a commit to matejvasek/faas that referenced this pull request Sep 27, 2023
* doc: Go and Rust on cluster build is supported

Signed-off-by: Matej Vasek <mvasek@redhat.com>

* doc: build envvars

Signed-off-by: Matej Vasek <mvasek@redhat.com>

---------

Signed-off-by: Matej Vasek <mvasek@redhat.com>
knative-prow bot pushed a commit that referenced this pull request Oct 2, 2023
* chore: use tkn tasks from PR branch in CI (#1914)

Signed-off-by: Matej Vasek <mvasek@redhat.com>

* chore: released binaries refer correct task yamls (#1916)

Signed-off-by: Matej Vasek <mvasek@redhat.com>

* chore: refer correct tkn yaml in prow test (#1918)

Without this change prow test will refer tkn yamls from the main branch
not from the PR head branch.

Signed-off-by: Matej Vasek <mvasek@redhat.com>

* chore: update release generation (#1924)

* Minimize release binary size.
* Release latest version of buildpack tekton task.

Signed-off-by: Matej Vasek <mvasek@redhat.com>

* test: update github ref used on e2e oncluster tests (#1917)

* test: Split of GH oncluster tests by builder. Added FUNC_BUILDER env var for e2e oncluter tests (#1963)

* Use our own s2i image (#1971)

Our image is much more recent and it is multiarch.

Signed-off-by: Matej Vasek <mvasek@redhat.com>

* chore: update buildah image ref (#1960)

Signed-off-by: Matej Vasek <mvasek@redhat.com>

* chore: update CA certs (#1944)

Signed-off-by: Matej Vasek <mvasek@redhat.com>

* chore: update Quarkus platform version to 3.4.1 (#1989)

Co-authored-by: Knative Automation <automation@knative.team>
Signed-off-by: Matej Vasek <mvasek@redhat.com>

* chore: update mvn wrapper in Quarkus template (#1987)

Signed-off-by: Matej Vasek <mvasek@redhat.com>

* chore: use ./mvnw not mvn in tests (#1988)

Signed-off-by: Matej Vasek <mvasek@redhat.com>

* chore: update Springboot platform version

Signed-off-by: Matej Vasek <mvasek@redhat.com>

* fix: docker registry/repository parsing (#1929)

* fix: docker registry/repository parsing

Use go-containerregistry to do parsing.

Signed-off-by: Matej Vasek <mvasek@redhat.com>

* fix: use kebab-case instead of camelCase

Signed-off-by: Matej Vasek <mvasek@redhat.com>

* fix: use kebab-case instead of camelCase

Signed-off-by: Matej Vasek <mvasek@redhat.com>

---------

Signed-off-by: Matej Vasek <mvasek@redhat.com>

* Fix failing concurrent test on Windows (#1890)

* src: better debugging

Signed-off-by: Matej Vasek <mvasek@redhat.com>

* fix: wait for both builds

Signed-off-by: Matej Vasek <mvasek@redhat.com>

* fixup

Signed-off-by: Matej Vasek <mvasek@redhat.com>

* fixup

Signed-off-by: Matej Vasek <mvasek@redhat.com>

* fixup

Signed-off-by: Matej Vasek <mvasek@redhat.com>

* fix: detection of process liveness on Windows

Signed-off-by: Matej Vasek <mvasek@redhat.com>

* fix: make symlink relative

Signed-off-by: Matej Vasek <mvasek@redhat.com>

* fixup: cleanup

Signed-off-by: Matej Vasek <mvasek@redhat.com>

---------

Signed-off-by: Matej Vasek <mvasek@redhat.com>

* allowing on cluster build for go runtime (#1445)

* allowing on cluster build for go runtime

* warning message added for go and rust builder

* gofmt

* fixups

Signed-off-by: Matej Vasek <mvasek@redhat.com>

---------

Signed-off-by: Matej Vasek <mvasek@redhat.com>
Co-authored-by: Matej Vasek <mvasek@redhat.com>

* Use custom jammy paketo builder (#1911)

* chore: use custom jammy paketo builder

Use our own modified jammy builder with additional buildpacks for
GoFunc and Rust. This enables on cluster build for Go and Rust functions.
Where possible (Go, Java) we use "tiny" variant, other runtimes use "base"
variant.

The updated task is new file instead of modifying existing task
this is done for sake of keeping compatiblility.

Signed-off-by: Matej Vasek <mvasek@redhat.com>

* fixup: remove unnecessary code per review request

Signed-off-by: Matej Vasek <mvasek@redhat.com>

* fixup

Signed-off-by: Matej Vasek <mvasek@redhat.com>

* fixup: podman test refers correct tkn task yamls

Signed-off-by: Matej Vasek <mvasek@redhat.com>

---------

Signed-off-by: Matej Vasek <mvasek@redhat.com>

* doc: Go and Rust on cluster build is supported (#1923)

* doc: Go and Rust on cluster build is supported

Signed-off-by: Matej Vasek <mvasek@redhat.com>

* doc: build envvars

Signed-off-by: Matej Vasek <mvasek@redhat.com>

---------

Signed-off-by: Matej Vasek <mvasek@redhat.com>

* fix: direct upload ppc64le, x390x (#1958)

Signed-off-by: Matej Vasek <mvasek@redhat.com>

* fix: report correct error when task doesn't exist (#1915)

Signed-off-by: Matej Vasek <mvasek@redhat.com>

* feat: tekton task urls in the env sub-cmd output (#1925)

Signed-off-by: Matej Vasek <mvasek@redhat.com>

---------

Signed-off-by: Matej Vasek <mvasek@redhat.com>
Co-authored-by: Jefferson Ramos <jeramos@redhat.com>
Co-authored-by: Knative Automation <automation@knative.team>
Co-authored-by: Shashank Sharma <48708039+Shashankft9@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants