-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-1.14] Update test dialer to use ip when available #971
[release-1.14] Update test dialer to use ip when available #971
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-1.14 #971 +/- ##
===============================================
Coverage ? 93.41%
===============================================
Files ? 36
Lines ? 1003
Branches ? 0
===============================================
Hits ? 937
Misses ? 53
Partials ? 13 ☔ View full report in Codecov by Sentry. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso, knative-prow-robot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Downstream actions don't work when the downstream doesn't have the same branches /override "Unit Test (knative/serving)" |
@dprotaso: Overrode contexts on behalf of dprotaso: Unit Test (knative-extensions/net-certmanager), Unit Test (knative-extensions/net-contour), Unit Test (knative-extensions/net-istio), Unit Test (knative-extensions/net-kourier), Unit Test (knative/serving) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
979f637
into
knative:release-1.14
This is an automated cherry-pick of #970