Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.14] Update test dialer to use ip when available #971

Conversation

knative-prow-robot
Copy link

This is an automated cherry-pick of #970

@knative-prow knative-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 18, 2024
Copy link

codecov bot commented Apr 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (release-1.14@a40d058). Click here to learn what that means.

Additional details and impacted files
@@               Coverage Diff               @@
##             release-1.14     #971   +/-   ##
===============================================
  Coverage                ?   93.41%           
===============================================
  Files                   ?       36           
  Lines                   ?     1003           
  Branches                ?        0           
===============================================
  Hits                    ?      937           
  Misses                  ?       53           
  Partials                ?       13           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dprotaso
Copy link
Member

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 18, 2024
Copy link

knative-prow bot commented Apr 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, knative-prow-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 18, 2024
@dprotaso
Copy link
Member

Downstream actions don't work when the downstream doesn't have the same branches

/override "Unit Test (knative/serving)"
/override "Unit Test (knative-extensions/net-certmanager)"
/override "Unit Test (knative-extensions/net-istio)"
/override "Unit Test (knative-extensions/net-contour)"
/override "Unit Test (knative-extensions/net-kourier)"

Copy link

knative-prow bot commented Apr 18, 2024

@dprotaso: Overrode contexts on behalf of dprotaso: Unit Test (knative-extensions/net-certmanager), Unit Test (knative-extensions/net-contour), Unit Test (knative-extensions/net-istio), Unit Test (knative-extensions/net-kourier), Unit Test (knative/serving)

In response to this:

Downstream actions don't work when the downstream doesn't have the same branches

/override "Unit Test (knative/serving)"
/override "Unit Test (knative-extensions/net-certmanager)"
/override "Unit Test (knative-extensions/net-istio)"
/override "Unit Test (knative-extensions/net-contour)"
/override "Unit Test (knative-extensions/net-kourier)"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot merged commit 979f637 into knative:release-1.14 Apr 18, 2024
24 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants