-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update test dialer to use ip when available #970
Conversation
@dprotaso is it ok to include this PR (once is merged) in the already created release-1.14 branch? |
Yeah I think it's fine to cherry pick once this merges since it's just some networking conformance test code |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #970 +/- ##
==========================================
- Coverage 93.43% 93.41% -0.02%
==========================================
Files 36 36
Lines 1249 1003 -246
==========================================
- Hits 1167 937 -230
+ Misses 69 53 -16
Partials 13 13 ☔ View full report in Codecov by Sentry. |
codegen timedout hitting go module cache /retest |
@andrew-su see the linter error |
the linter is still going off |
/lgtm @izabelacg feel free to cherry-pick |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andrew-su, dprotaso The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-1.14 |
@izabelacg: new pull request created: #971 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
With the changes to knative-extensions/net-gateway-api#685 where it is possible to have the ingress's public loadbalancer point to an IP instead of domain, we should use the value provided.
Changes
/kind bug
/king cleanup