Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test dialer to use ip when available #970

Merged
merged 2 commits into from
Apr 18, 2024

Conversation

andrew-su
Copy link
Member

With the changes to knative-extensions/net-gateway-api#685 where it is possible to have the ingress's public loadbalancer point to an IP instead of domain, we should use the value provided.

Changes

  • 🐛 Don't expect there to only be domains, sometimes it might be an IP

/kind bug
/king cleanup

@knative-prow knative-prow bot added the kind/bug Categorizes issue or PR as related to a bug. label Apr 18, 2024
@knative-prow knative-prow bot requested review from izabelacg and skonto April 18, 2024 16:54
@knative-prow knative-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 18, 2024
@izabelacg
Copy link
Member

@dprotaso is it ok to include this PR (once is merged) in the already created release-1.14 branch?

@dprotaso
Copy link
Member

Yeah I think it's fine to cherry pick once this merges since it's just some networking conformance test code

@knative-prow knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 18, 2024
Copy link

codecov bot commented Apr 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.41%. Comparing base (75762ca) to head (c6b8408).
Report is 13 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #970      +/-   ##
==========================================
- Coverage   93.43%   93.41%   -0.02%     
==========================================
  Files          36       36              
  Lines        1249     1003     -246     
==========================================
- Hits         1167      937     -230     
+ Misses         69       53      -16     
  Partials       13       13              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dprotaso
Copy link
Member

codegen timedout hitting go module cache

/retest

@dprotaso
Copy link
Member

@andrew-su see the linter error

@dprotaso
Copy link
Member

the linter is still going off

@dprotaso
Copy link
Member

/lgtm
/approve

@izabelacg feel free to cherry-pick

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 18, 2024
Copy link

knative-prow bot commented Apr 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrew-su, dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 18, 2024
@knative-prow knative-prow bot merged commit 24ed062 into knative:main Apr 18, 2024
27 checks passed
@izabelacg
Copy link
Member

/cherry-pick release-1.14

@knative-prow-robot
Copy link

@izabelacg: new pull request created: #971

In response to this:

/cherry-pick release-1.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants