-
Notifications
You must be signed in to change notification settings - Fork 329
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Avoid importing apis/duck from apis/duck/<<version>>
- Loading branch information
1 parent
eb05e8d
commit c30d649
Showing
16 changed files
with
211 additions
and
172 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| /* | ||
| Copyright 2020 The Knative Authors | ||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
|
|
||
| package ducktypes | ||
|
|
||
| import ( | ||
| "knative.dev/pkg/apis" | ||
| ) | ||
|
|
||
| // Implementable is implemented by the Fooable duck type that consumers | ||
| // are expected to embed as a `.status.fooable` field. | ||
| type Implementable interface { | ||
| // GetFullType returns an instance of a full resource wrapping | ||
| // an instance of this Implementable that can populate its fields | ||
| // to verify json roundtripping. | ||
| GetFullType() Populatable | ||
| } | ||
|
|
||
| // Populatable is implemented by a skeleton resource wrapping an Implementable | ||
| // duck type. It will generally have TypeMeta, ObjectMeta, and a Status field | ||
| // wrapping a Fooable field. | ||
| type Populatable interface { | ||
| apis.Listable | ||
|
|
||
| // Populate fills in all possible fields, so that we can verify that | ||
| // they roundtrip properly through JSON. | ||
| Populate() | ||
| } | ||
|
|
||
| const GroupName = "duck.knative.dev" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,78 @@ | ||
| /* | ||
| Copyright 2020 The Knative Authors | ||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
|
|
||
| package duck | ||
|
|
||
| import ( | ||
| "testing" | ||
|
|
||
| appsv1 "k8s.io/api/apps/v1" | ||
| batchv1 "k8s.io/api/batch/v1" | ||
|
|
||
| "knative.dev/pkg/apis/duck/v1" | ||
| ) | ||
|
|
||
| // Conditions is an Implementable "duck type". | ||
| var _ Implementable = (*v1.Conditions)(nil) | ||
|
|
||
| // In order for Conditions to be Implementable, KResource must be Populatable. | ||
| var _ Populatable = (*v1.KResource)(nil) | ||
|
|
||
| // Source is an Implementable "duck type". | ||
| var _ Implementable = (*v1.Source)(nil) | ||
|
|
||
| // Verify Source resources meet duck contracts. | ||
| var _ Populatable = (*v1.Source)(nil) | ||
|
|
||
| var _ Populatable = (*v1.WithPod)(nil) | ||
| var _ Implementable = (*v1.PodSpecable)(nil) | ||
|
|
||
| func TestV1TypesImplements(t *testing.T) { | ||
| testCases := []struct { | ||
| instance interface{} | ||
| iface Implementable | ||
| }{ | ||
| {instance: &v1.AddressableType{}, iface: &v1.Addressable{}}, | ||
| {instance: &v1.KResource{}, iface: &v1.Conditions{}}, | ||
| } | ||
| for _, tc := range testCases { | ||
| if err := VerifyType(tc.instance, tc.iface); err != nil { | ||
| t.Error(err) | ||
| } | ||
| } | ||
| } | ||
|
|
||
| func TestV1ImplementsPodSpecable(t *testing.T) { | ||
| instances := []interface{}{ | ||
| &v1.WithPod{}, | ||
| &appsv1.ReplicaSet{}, | ||
| &appsv1.Deployment{}, | ||
| &appsv1.StatefulSet{}, | ||
| &appsv1.DaemonSet{}, | ||
| &batchv1.Job{}, | ||
| } | ||
| for _, instance := range instances { | ||
| if err := VerifyType(instance, &v1.PodSpecable{}); err != nil { | ||
| t.Error(err) | ||
| } | ||
| } | ||
| } | ||
|
|
||
| // Addressable is an Implementable "duck type". | ||
| var _ Implementable = (*v1.Addressable)(nil) | ||
|
|
||
| // Verify AddressableType resources meet duck contracts. | ||
| var _ Populatable = (*v1.AddressableType)(nil) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.