Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reflector metrics are not available #2019

Closed
skonto opened this issue Feb 12, 2021 · 1 comment · Fixed by #2020
Closed

Reflector metrics are not available #2019

skonto opened this issue Feb 12, 2021 · 1 comment · Fixed by #2020

Comments

@skonto
Copy link
Contributor

skonto commented Feb 12, 2021

Expected Behavior

See reflector metrics exported

Actual Behavior

No reflector metrics are exported

Steps to Reproduce the Problem

  1. Installed v0.19.0 for Knative Serving on OCP, K8s version v1.18.2.
  2. Port-forward and listed metrics for the Controller pod, for a dump check here

It seems this is due to kubernetes/kubernetes#74636 check relevant discussion here kubernetes-sigs/controller-runtime#817. Not sure if this has been discussed before, I see a related comment here. Should we remove these metrics?

/cc @mattmoor @evankanderson @vaikas

@skonto
Copy link
Contributor Author

skonto commented Feb 15, 2021

I dug into the knative/pkg commit history, so the metrics have been stopped from being used from this commit Upgrade kubernetes-1.12.6 -> kubernetes-1.12.9 (#508) and on. Also have been removed from the upstream client-go repo here same date when they were stop being exposed from the k8s code. It is safe to remove or at least de-activate them by using some dummy provider as in here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant