Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Samples should be standalone #1291

Closed
steren opened this issue Jun 20, 2018 · 3 comments
Closed

Samples should be standalone #1291

steren opened this issue Jun 20, 2018 · 3 comments
Assignees
Labels
area/build Build topics specifically related to Knative kind/doc Something isn't clear

Comments

@steren
Copy link
Contributor

steren commented Jun 20, 2018

/area build
/kind doc

Keep things simple. Each sample folder should contain all it needs to be followed.

Expected Behavior

Each sample folder should contain all thing necessary to build and deploy.
For example, I expect a Dockerfile in this folder

Actual Behavior

Sample folders depend on a common Dockerfile that expects a certain folder structure and argument: RUN CGO_ENABLED=0 go build ./sample/${SAMPLE}

This prevent to easily re-use the samples and requires developers to adjust the samples to their setup.

@google-prow-robot google-prow-robot added area/build Build topics specifically related to Knative kind/doc Something isn't clear labels Jun 20, 2018
@steren
Copy link
Contributor Author

steren commented Jun 20, 2018

Also evaluate moving samples to their own repo.
This would allow for a better separation of concerns, improve discoverability and facilitate community contributions

@rgregg
Copy link
Contributor

rgregg commented Jun 27, 2018

I'm fixing this as part of the move to knative/docs.

@mattmoor
Copy link
Member

samples are moved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build Build topics specifically related to Knative kind/doc Something isn't clear
Projects
None yet
Development

No branches or pull requests

4 participants