The conformance test ContainerExitingMsg is very flaky and currently dependant on a custom progressDeadline

[norman465]

The conformance test ContainerExitingMsg seems to be very flaky. From what I understand the test wants to hit this code here to set the revision to False if the pod crashes repeatedly. However, this is almost never reached since the deployment is reconciled every time (#13204) and may run into a race condition while trying to update it preventing it from ever reaching that code.

In what area(s)?

/area API
/area test-and-release

What version of Knative?

1.6+

Expected Behavior

Conformance test ContainerExitingMsg passes.

Actual Behavior

Conformance test ContainerExitingMsg is not passed with knative defaults.
https://github.com/knative/serving/actions/runs/3444537426/jobs/5747350496
PASS test/conformance/api/v1.TestContainerExitingMsg (121.05s) this is using customized values in the knative pipeline and passes only because the custom progressDeadline is set to 120s (https://github.com/knative/serving/blob/main/test/config/ytt/core/overlay-config-deployment.yaml). The actual default ProgressDealine is set to 10m (the same as the default timeout of the conformance tests) which would prevent this test from passing most of the time.

Steps to Reproduce the Problem

Run the conformance tests with a 10m timeout on a knative installation with a default progressDeadline of 10m.

[psschwei]

I wonder if a simple solution would be to increase the default timeout to 11 minutes?

serving/test/util.go

Line 40 in aebc16c

PollTimeout = 10 * time.Minute

[github-actions]

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.