Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TestUpdate is very flaky, needs investigation #8032

Closed
tcnghia opened this issue May 21, 2020 · 1 comment
Closed

TestUpdate is very flaky, needs investigation #8032

tcnghia opened this issue May 21, 2020 · 1 comment
Labels
area/networking area/test-and-release It flags unit/e2e/conformance/perf test issues for product features kind/bug Categorizes issue or PR as related to a bug.
Milestone
0.17.x

Comments

@tcnghia
Copy link
Contributor

tcnghia commented May 21, 2020

What version of Knative?

v0.15

Actual Behavior

TestUpdate is very flaky, so we temporarily Skip() it.

Expected Behavior

We should fix the flake and reinstate the test.

Steps to Reproduce the Problem
@tcnghia tcnghia added the kind/bug Categorizes issue or PR as related to a bug. label May 21, 2020
This was referenced May 21, 2020
Closed
Merged
tcnghia pushed a commit to tcnghia/serving that referenced this issue May 23, 2020
Skip TestUpdate due to excessive flaking.
2a46cba 
We don't want to just do t.Skip() since the test may still be useful for
net-* repositories.  knative#8032
tracks work to fix the test.
@tcnghia tcnghia mentioned this issue May 23, 2020
Closed
@vagababov vagababov mentioned this issue May 25, 2020
Closed
@tcnghia tcnghia added this to the Serving 0.16.x milestone Jun 2, 2020
@tcnghia tcnghia added area/networking area/test-and-release It flags unit/e2e/conformance/perf test issues for product features labels Jun 2, 2020
@dprotaso dprotaso modified the milestones: Serving 0.16.x, 0.17.x Jul 8, 2020
@mattmoor
Copy link
Member

This is no longer skipped or even run in this repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/networking area/test-and-release It flags unit/e2e/conformance/perf test issues for product features kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
0.17.x
Development

No branches or pull requests
3 participants
@dprotaso @tcnghia @mattmoor