Increase webhook resources & skip TestUpdate to reduce test flakes #8048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow-robot
added
size/XS
There was a problem hiding this comment.
@tcnghia: 0 warnings.
In response to this:
Fixes #
Proposed Changes
- Increase webhook resources to attempt to reduce test flakes
- Also skip flaky test TestUpdate (tracked now in TestUpdate is very flaky, needs investigation #8032, and also tested as part of net-*'s integration tests)
Release Note
NONE
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
knative-prow-robot
added
the
area/test-and-release
tcnghia
changed the title
tcnghia
force-pushed
the
increase-webhook-resources
branch
from
a3d08ab
to
d30b3a3
Compare
tcnghia
force-pushed
the
increase-webhook-resources
branch
from
d30b3a3
to
8a1ea7c
Compare
|
/hold |
knative-prow-robot
added
the
do-not-merge/hold
|
/test pull-knative-serving-integration-tests |
|
(all previous 3 runs were failing TestUpdate) |
|
/hold cancel |
knative-prow-robot
removed
the
do-not-merge/hold
|
/test pull-knative-serving-integration-tests |
knative-prow-robot
added
needs-rebase
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tcnghia The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
removed
the
needs-rebase
tcnghia
changed the title
vagababov
reviewed
May 23, 2020
tcnghia
force-pushed
the
increase-webhook-resources
branch
from
0263e4f
to
465a6e3
Compare
knative-prow-robot
added
the
needs-rebase
knative-prow-robot
removed
the
needs-rebase
|
The following jobs failed:
Automatically retrying due to test flakiness... |
|
/lgtm |
knative-prow-robot
added
do-not-merge/hold
|
looks like passing |
knative-prow-robot
removed
the
do-not-merge/hold
This was referenced Jul 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Proposed Changes
Release Note