Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Typing] Add types for analytic functions #4544

Merged
merged 2 commits into from
Jun 29, 2021
Merged

[Typing] Add types for analytic functions #4544

merged 2 commits into from
Jun 29, 2021

Conversation

nguymin4
Copy link
Contributor

@nguymin4 nguymin4 commented Jun 29, 2021 •
edited
Loading

Add typing for new analytic functions i.e rowNumber, rank, denseRank

@nguymin4 nguymin4 changed the title nguymin4/typing analytics [Typing] Add types for analytic functions Jun 29, 2021
@nguymin4
Copy link
Contributor Author

Hi @kibertoad, could you take a look at this? Thank you.

@kibertoad kibertoad merged commit 228b49f into knex:master Jun 29, 2021
@kibertoad
Copy link
Collaborator

Thanks a lot!

@nguymin4 nguymin4 deleted the nguymin4/typing-analytics branch June 29, 2021 18:28
@kibertoad
Copy link
Collaborator

Released in 0.95.7

@nguymin4 nguymin4 mentioned this pull request Jul 20, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kibertoad kibertoad kibertoad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nguymin4 @kibertoad