Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disconf 一处硬编码问题com.baidu.disconf.core.common.restful.impl.RestfulMgrImpl #53

Closed
wanglei1598 opened this issue Dec 30, 2015 · 2 comments

Comments

@wanglei1598
Copy link

com.baidu.disconf.core.common.restful.impl.RestfulMgrImpl
private File retryDownload(String fileName, RemoteUrl remoteUrl, int retryTimes, int retrySleepSeconds)
throws Exception {

    String tmpFileDir = "./disconf/download";   //为什么要硬编码………………  有没有考虑到可能有问题
    String tmpFilePath = OsUtil.pathJoin(tmpFileDir, fileName);
    String tmpFilePathUnique = MyStringUtils.getRandomName(tmpFilePath);
    File tmpFilePathUniqueFile = new File(tmpFilePathUnique);
    retry4ConfDownload(remoteUrl, tmpFilePathUniqueFile, retryTimes, retrySleepSeconds);

    return tmpFilePathUniqueFile;
}
@knightliao
Copy link
Owner

在sys配置文件里有,我没有用上。https://github.com/knightliao/disconf/blob/master/disconf-client/src/main/resources/disconf_sys.properties
我下个版本 fix,感谢提醒

@knightliao
Copy link
Owner

fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants