Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further fix on proper parsing of proprietary messages #46

Closed
randallpittman opened this issue Nov 23, 2015 · 0 comments
Closed

Further fix on proper parsing of proprietary messages #46

randallpittman opened this issue Nov 23, 2015 · 0 comments

Comments

@randallpittman
Copy link
Contributor

My fix for issue #44 had the wrong indexes since I foolishly copied it directly from the ubx.py code.

the proper __init__ method should have been the following:

    def __init__(self, manufacturer, data):
        self.sentence_type = manufacturer + data[0]
        super(GRM, self).__init__(manufacturer, data[1:])

This same method (with SRF) should be added to srf.py

Knio added a commit that referenced this issue Nov 24, 2015
Issue #46 - Proper parsing of GRM and SRF messages
@Knio Knio closed this as completed Nov 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants