Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource in @export statements is not used to determine the output path #449

Closed
mmarx opened this issue Jan 7, 2024 · 2 comments
Closed
Assignees
Labels
bug Something isn't working io
Milestone

Comments

@mmarx
Copy link
Member

mmarx commented Jan 7, 2024

Currently, for any @export statement, the output path is based solely on the base output path and the predicate name. The resource attribute should be used instead of the predicate name.

@mmarx mmarx added bug Something isn't working io labels Jan 7, 2024
@mmarx mmarx added this to the Release 0.5.0 milestone Jan 7, 2024
@mmarx mmarx self-assigned this Jan 7, 2024
@mmarx mmarx added this to nemo Jan 7, 2024
@github-project-automation github-project-automation bot moved this to Todo in nemo Jan 7, 2024
@mkroetzsch
Copy link
Member

Some details of how this should behave may need to be specified, since we have global settings in OutputManager and local setting in individual exports. Suggestion:

  • Exports already require a "resource" (file name) to be given. This would also define the compression method (by the extension), no matter what is set globally.
  • If exports specify relative paths, then they should be relative to the base path of the OutputManager.

@mmarx mmarx modified the milestones: Release 0.5.0, Release 0.6.0 Apr 3, 2024
@mmarx
Copy link
Member Author

mmarx commented Apr 5, 2024

Pretty sure that this got resolved with the new data model in Nemo 0.5.0.

@mmarx mmarx closed this as completed Apr 5, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in nemo Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working io
Projects
Archived in project
Development

No branches or pull requests

2 participants