Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

visibility: hidden vs. display: none for tab-views #1

Closed
Thyraz opened this issue Jan 28, 2020 · 3 comments
Closed

visibility: hidden vs. display: none for tab-views #1

Thyraz opened this issue Jan 28, 2020 · 3 comments

Comments

@Thyraz
Copy link
Contributor

Thyraz commented Jan 28, 2020

Hi Mario,

I already have a first question. ;)

Currently the tab widgets uses visibility: hidden to hide a view.
This works fine when used in the grid system, as elements which use the same columns/rows are layered above each other.

But if you try to use this without the grid system, the elements still reserve the space on the screen, as hidden: invisible only hides them, but doesn't set the size to zero.
So I would like to ask it this can be changed to display: none.

I already tested your sample files with this fix and they still render the same way.

Regards,
Tobias

@knowthelist
Copy link
Owner

display: none was also my first choice, but elements with display: none has zero dimensions what causes trouble on components which need these for position calculation like slider (Rangeable). As an other solution for this problem we could emit a custom 'visibilityChanged' and the slider must subscribe this event and re-render it self.

@Thyraz
Copy link
Contributor Author

Thyraz commented Jan 28, 2020

Ok, so this was the problem with the slider widget a few days ago?
In this case, maybe sticking with visibility: hidden would be the better idea.

Even if someone (me) wants to build a layout without the default grid, there's most likely a way to build a similar layout with divs stacked on top of each other.

I currently try to build a responsive/mobile layout with a fixed footer and will report how it works out that way. ;)

I guess wrapping the single parts of the UI in fixed divs might work.

@Thyraz
Copy link
Contributor Author

Thyraz commented Jan 29, 2020

Ok, stacking fixed divs works fine.
So I close this request. :)

@Thyraz Thyraz closed this as completed Jan 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants