Fix warning message

knqyf263 · May 15, 2019 · 77e9b0a · 77e9b0a
1 parent cfd85db
commit 77e9b0a
Showing 1 changed file with 12 additions and 19 deletions.
diff --git a/pkg/scanner/scan.go b/pkg/scanner/scan.go
@@ -6,40 +6,33 @@ import (
 	"fmt"
 	"os"
 
-	"golang.org/x/crypto/ssh/terminal"
-
 	"github.com/genuinetools/reg/registry"
-
+	"github.com/knqyf263/fanal/analyzer"
+	"github.com/knqyf263/fanal/extractor"
 	"github.com/knqyf263/trivy/pkg/log"
-
 	"github.com/knqyf263/trivy/pkg/scanner/library"
-
-	"github.com/knqyf263/trivy/pkg/vulnsrc/vulnerability"
-
 	"github.com/knqyf263/trivy/pkg/scanner/ospkg"
-
+	"github.com/knqyf263/trivy/pkg/vulnsrc/vulnerability"
+	"golang.org/x/crypto/ssh/terminal"
 	"golang.org/x/xerrors"
-
-	"github.com/knqyf263/fanal/analyzer"
-	"github.com/knqyf263/fanal/extractor"
 )
 
 func ScanImage(imageName, filePath string) (map[string][]vulnerability.DetectedVulnerability, error) {
 	var err error
 	results := map[string][]vulnerability.DetectedVulnerability{}
 	ctx := context.Background()
 
-	image, err := registry.ParseImage(imageName)
-	if err != nil {
-		return nil, xerrors.Errorf("invalid image: %w", err)
-	}
-	if image.Tag == "latest" {
-		log.Logger.Warn("You should avoid using the :latest tag as it is cached. You need to specify '--clean' option when :latest image is changed")
-	}
-
 	var target string
 	var files extractor.FileMap
 	if imageName != "" {
+		image, err := registry.ParseImage(imageName)
+		if err != nil {
+			return nil, xerrors.Errorf("invalid image: %w", err)
+		}
+		if image.Tag == "latest" {
+			log.Logger.Warn("You should avoid using the :latest tag as it is cached. You need to specify '--clear-cache' option when :latest image is changed")
+		}
+
 		target = imageName
 		files, err = analyzer.Analyze(ctx, imageName)
 		if err != nil {