Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IE Support issue #142

Closed
tylerlong opened this issue Mar 21, 2015 · 11 comments
Closed

IE Support issue #142

tylerlong opened this issue Mar 21, 2015 · 11 comments

Comments

@tylerlong
Copy link
Collaborator

Online demo: http://mdp.tylingsoft.com/ Please scroll to the bottom and you will see the flowchart and sequence diagram.

Tested on Windows 8.1 64 bit, IE 11. Here is a screenshot:

image

Yes I found this issue #99 I think I might be able to fix the flowchart issue.

But there is also issue with the sequence diagram. You can see that the two vertical lines are too long.

@knsv
Copy link
Collaborator

knsv commented Mar 22, 2015

Thanks, will take a look!

@tylerlong
Copy link
Collaborator Author

I confirm that flowchart issue could be solved by:

var mermaid_config = {
  htmlLabels: false
};

@tylerlong
Copy link
Collaborator Author

I have found the root cause to the sequence diagram vertical line too long issue. It is caused by this line:

https://github.com/knsv/mermaid/blob/a38a156d3b26c21b715dbe9a9f47e3ff27edb9e4/src/diagrams/sequenceDiagram/svgDraw.js#L78

.attr("y2", 2000)

2000 is a hard coded large value.

@tylerlong
Copy link
Collaborator Author

A workaround for the sequence diagram issue is:

$('line[y2="2000"]').each(function(){
  $(this).attr('y2', $(this).closest('svg').attr('height') - 10);
});

@knsv
Copy link
Collaborator

knsv commented Mar 24, 2015

Thanks!. Did you manage to fix the styling for the flowcharts? If so I can add that to the default styling mermaid.css

@tylerlong
Copy link
Collaborator Author

No, I didn't change the style of flowcharts. I fixed it by:

var mermaid_config = {
  htmlLabels: false
};

@knsv
Copy link
Collaborator

knsv commented May 13, 2015

@tylerlong do you think I can close this one? I am going through the issues and compiling them to a roadmap.

@tylerlong
Copy link
Collaborator Author

Yes, you can close it. But please don't ignore the following content:

I have found the root cause to the sequence diagram vertical line too long issue. It is caused by this line:

https://github.com/knsv/mermaid/blob/a38a156d3b26c21b715dbe9a9f47e3ff27edb9e4/src/diagrams/sequenceDiagram/svgDraw.js#L78

.attr("y2", 2000)

2000 is a hard coded large value.

Since I've already found the root cause, it should be easy to fix.

@knsv
Copy link
Collaborator

knsv commented Oct 4, 2015

OK, closing. The y2 200o is no longer there. It is initially set to to 200 but updated after rendering.

@knsv knsv closed this as completed Oct 4, 2015
@madhu72
Copy link

madhu72 commented Dec 11, 2015

Hi even added htmlLabels:false, I am not seeing labels in IE 11

@madhu72
Copy link

madhu72 commented Dec 11, 2015

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants