Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't render subgraphs with htmlLabels: false #367

Closed
RReverser opened this issue Jun 21, 2016 · 6 comments
Closed

Can't render subgraphs with htmlLabels: false #367

RReverser opened this issue Jun 21, 2016 · 6 comments

Comments

@RReverser
Copy link

Tracked this to addSVGLabel which fails because for clusters, nodes are created with labelType: "svg" and label: "", so it tries to insert label which is a string, using appendNode, hence the error.

@ghosert
Copy link

ghosert commented Jun 23, 2016

+1, will this be fixed soon. Thanks. ;)

@RReverser
Copy link
Author

@ghosert Just another sidenote: please don't do +1 on github issues, this is a very bad practice. Just use Github's reactions ( 👍 ) on issues, or you can even try to fix it yourself and send a PR.

@ghosert
Copy link

ghosert commented Jun 23, 2016

For example, would like to see this text rendering correctly:

 subgraph one
 a1-->a2
 end
 subgraph two
 b1-->b2
 end
 subgraph three
 c1-->c2
 end
 c1-->a2

@ghosert
Copy link

ghosert commented Oct 10, 2016

@shd101wyy I don't think we are saying the same issue, your fix may not be the solution for this issue.

@daveaglick
Copy link
Contributor

Just submitted a PR for this - thanks for the starting point @RReverser, JS isn't my main language so I couldn't have figured this out without knowing where to start looking.

@knsv
Copy link
Collaborator

knsv commented Jan 29, 2017

Closed by release 7.0.0, please reopen if issues remain.

@knsv knsv closed this as completed Jan 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants