Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using QUnit for AMD testing #190

Merged
merged 4 commits into from
Jul 22, 2015
Merged

Using QUnit for AMD testing #190

merged 4 commits into from
Jul 22, 2015

Conversation

bollwyvl
Copy link
Contributor

This adds bower-managed QUnit testing for #127. I am not a particular fan of QUnit, but it seemed like the simplest thing to set up for this kind of use case.

The fix was indeed just turning standalone back on, which I thought I had tried, but so it goes. But the important thing is the test and integration into gulp, I suppose.

It does make the build a lot longer, but I wanted to make sure travis liked it. Perhaps putting standalone behind a flag? Since the fix is so simple but expensive, it really doesn't need to be run all the time. I am not much of a gulp wizard, so I don't know how one would go about doing that... environment variables are sometimes the easiest way :P

Also, I found it a bit odd that test didn't include a dist precursor... I've added it crudely to package.json, but let me know why you wouldn't want travis to ensure the build is working :)

@knsv
Copy link
Collaborator

knsv commented Jul 22, 2015

Thanks! Merging!

knsv added a commit that referenced this pull request Jul 22, 2015
Using QUnit for AMD testing
@knsv knsv merged commit 80912ff into mermaid-js:master Jul 22, 2015
@bollwyvl
Copy link
Contributor Author

Let me know if the build/browser tests are taking too long... We can figure
out something!

On 02:47, Wed, Jul 22, 2015 Knut Sveidqvist notifications@github.com
wrote:

Merged #190 #190.


Reply to this email directly or view it on GitHub
#190 (comment).

mgenereu pushed a commit to mgenereu/mermaid that referenced this pull request Jun 25, 2022
…yarn/develop/typescript-4.3.2

Bump typescript from 4.2.4 to 4.3.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants