-
-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/allow inclusive enddates #872
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will essentially keep all old behavior the same while still allowing users to specify if they want inclusive end dates
now it just checks if a valid end time was provided and instead of the comparison that went on before. This needed to be done in order to support manual end dates with inclusive set to true since they don't match anymore as the 'manually' supplied end date is increased by one
if a line contains inclusiveEndDates then it will toggle the chart to use inclusive end dates
ThePenguin1140
added
Type: Enhancement
New feature or request
Status: Approved
Is ready to be worked on
Priority: Normal
Graph: Gantt
labels
Jul 7, 2019
Pull Request Test Coverage Report for Build 804
💛 - Coveralls |
codeclimate was complaining about the getEndDate function so I split it up
knsv
reviewed
Jul 12, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be good if the diagrams you added to index.html also are added as e2e tests under e2e. This will make sure this functionality is not broken at a later date.
This was referenced Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the addition of a
inclusiveEndDates
arguments for Gantt chart definitions.Adding this argument will add 1 day to all the end dates, effectively treating them to be inclusive.
Relevant Issues:
Tasks:
Example Usage: