This repository has been archived by the owner on Jan 30, 2024. It is now read-only.
toggle RTT mode after RAM initialization #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
japaric
commented
Sep 21, 2020
src/main.rs
Outdated
| log::warn!("device doesn't support HW breakpoints; HardFault will NOT make `probe-run` exit with an error code"); | ||
| } else { | ||
| core.set_hw_breakpoint(vector_table.hard_fault & !THUMB_BIT)?; | ||
| bail!("device without HW breakpoints are not supported"); |
There was a problem hiding this comment.
FIXME: we should only bail if rtt_addr is Some
japaric
commented
Sep 21, 2020
| @@ -933,6 +943,7 @@ fn rtt_and_heap_info_from( | |||
| }; | |||
|
|
|||
| match name { | |||
| "main" => main = Some(symbol.address() as u32 & !THUMB_BIT), | |||
There was a problem hiding this comment.
I don't think this symbol is guaranteed to exist in the final binary so we may want to do something else
There was a problem hiding this comment.
At least when using cortex-m-rt it will always exist, I think
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on knurling-rs/defmt#174
closes knurling-rs/defmt#133