Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

defmt-rtt: add non-blocking mode; set it as the default #174

Merged
merged 1 commit into from
Sep 22, 2020
Merged

defmt-rtt: add non-blocking mode; set it as the default #174

merged 1 commit into from
Sep 22, 2020

Conversation

japaric
Copy link
Member

@japaric japaric commented Sep 21, 2020 •
edited
Loading

do not merge until there's a probe-run PR that changes the mode back to blocking at runtime
should be merged around at the same time as knurling-rs/probe-run#69

@japaric
Copy link
Member Author

japaric commented Sep 21, 2020

this should be tested outside a probe-run environment: it should not block and it should not corrupt memory (have not tested myself)

@japaric japaric mentioned this pull request Sep 21, 2020
Merged
@japaric japaric marked this pull request as ready for review September 21, 2020 14:49
@jonas-schievink jonas-schievink merged commit ba765be into main Sep 22, 2020
@Lotterleben Lotterleben deleted the nonblocking-rtt branch September 25, 2020 11:18
@rihardsk rihardsk mentioned this pull request May 22, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonas-schievink jonas-schievink jonas-schievink approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@japaric @jonas-schievink