Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/metrics aren't displayed, downloaded instead #6

Closed
simonszu opened this issue Nov 7, 2016 · 2 comments
Closed

/metrics aren't displayed, downloaded instead #6

simonszu opened this issue Nov 7, 2016 · 2 comments

Comments

@simonszu
Copy link

simonszu commented Nov 7, 2016

Hi,

not really an issue, but a question instead. It seems that any browser does not recognize the /metrics path as a text file it can display, but as a binary (or other file type it can't handle), so it downloads the file instead. When viewing the downloaded file with a text editor it looks fine.
So i am questioning myself if i haven't set up this plugin correctly, and prometheus itself will fail interpreting the /metrics as well, or if everything is fine?
If this is the expected behaviour, maybe you could specify some kind of output MIME-type so that the average browser can handle the output?
This would prevent other noobs like me who have very little experience with the collaboration of nginx and lua from searching for errors when there are none.

@knyar knyar closed this as completed in 31c4b2f Nov 7, 2016
@knyar
Copy link
Owner

knyar commented Nov 7, 2016

I think the latest commit should fix this.

@simonszu
Copy link
Author

simonszu commented Nov 8, 2016

It does. Thank you very much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants