Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor global values to be defaults #1318

Merged
merged 2 commits into from
May 21, 2024
Merged

Refactor global values to be defaults #1318

merged 2 commits into from
May 21, 2024

Commits on May 18, 2024

  1. Refactor global values to be defaults

    There was recent work to add global values for `env`, `flags`, and `ldflags`. The global values would be merged with per-build values to generate the value used for the builds.
    
    There are a couple issues with this:
    
    - It's inconsistent with the existing code, which only has `default` values declared globally (there is no merging today).
    - The name of the `flag` variable, caused a conflict with knative's `KO_FLAGS` environment variable (see ko-build#1317)
    
    This PR does the following:
    
    - Refactors the logic to use `defaultEnv`, `defaultFlags`, and `defaultLdflags`. This resolves both issues described above.
    - Updates documentation
    
    Fixes ko-build#1317
    nmittler committed May 18, 2024
    Configuration menu
    Copy the full SHA
    c953c97 View commit details
    Browse the repository at this point in the history

Commits on May 21, 2024

  1. Update integration_test.sh

    imjasonh committed May 21, 2024
    Configuration menu
    Copy the full SHA
    658cd72 View commit details
    Browse the repository at this point in the history