New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

base-auth/app.js #76

Closed

ghost opened this issue Apr 22, 2016 · 0 comments · May be fixed by zakyke/examples#5

ghost commented Apr 22, 2016

app.use(function* (next){
  try {
    yield* next;
  } catch (err) {
    if (401 == err.status) {
      this.status = 401;
      this.body = 'cant haz that';
    } else {
      throw err;
    }
  }
});

==>

app.use(function *(next){
  try {
    yield next;
  } catch (err) {
    if (401 == err.status) {
      this.status = 401;
      this.set('WWW-Authenticate', 'Basic');
      this.body = 'cant haz that';
    } else {
      throw err;
    }
  }
});

bananaappletw mentioned this issue

Fix basic-auth example doesn't prompt form to login #85

Merged

hemanth closed this as completed in #85

zakyke mentioned this issue

[Snyk] Fix for 2 vulnerabilities zakyke/examples#5

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment