-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
All JWT-related functions should be yieldable #32
Comments
Personally, I don't think it's the responsibility of this middleware to expose such methods, as the client can use the Thoughts, @stiang? |
@tejasmanohar I think I agree. In retrospect, it seems like a mistake to "forward" these methods, since it goes against the node philosophy of having small modules that do their one thing well. If you need these methods, you should require jsonwebtoken in your code. |
Yep, agreed. Will look into it and send PRs either today/tomorrow evening. Maybe we can bump a version with some of the existing PRs and these changes soon :) |
That would be awesome! We’ll need to bump the version quite a bit, though, since removing the jsonwebtoken functions is likely to break existing code. |
Yep, makes sense to merge stuff into a v2 branch and prepare for that release- following semver. |
If you ask me, we should start thinking about making it working with |
@leo Koa authors state that they will maintain |
@vsviridov Yeah, that's true! However, I see many devs that are using Babel to transpile their code before running it.... 😊 |
@leo, yeah, i guess. But I feel that it's sooo clunky on server-side... |
@stiang I believe this should be closed. jsonwebtoken functions are no longer begin "forwarded". |
Does it mean we must |
@tejasmanohar yes, but it seems |
@fancyoung Be aware that if you install Also, this issue really needs to be closed. |
not just verify
The text was updated successfully, but these errors were encountered: