-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Bluebird #74
Comments
My last comment on #58:
Thoughts? |
The docs say a promise is returned. This is why I was surprised to find bluebird was brought in to wrap a single function. I don't see an issue bumping the major version to be safe. Really wish koa would go full on v2 |
I (kinda) agree on the "misusage" of the API argument. It's a case of "penalizing" not-so-good users. Personally, I wouldn't mind a minor bump for this. But since we cannot safe-guard against all breaking changes, I'd also include some comment on the docs, somewhere. Maybe on the |
Koa@2.0.1 has released! It's time to face this issue. I think sindresorhus/pify is a good choice. It use native Promise default. |
Although #58 shows as merged, the changes were not incorporated due to the ongoing discussion, and were reverted by a subsequent commit. Unfortunately merging #72 caused GitHub to mark #58 as merged and will not let me re-open that PR (sorry @scttcper!).
The text was updated successfully, but these errors were encountered: