Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeScript rewrite? #1475

Closed
kubejm opened this issue Jun 25, 2020 · 3 comments
Closed

TypeScript rewrite? #1475

kubejm opened this issue Jun 25, 2020 · 3 comments

Comments

@kubejm
Copy link
Contributor

kubejm commented Jun 25, 2020

As of recent, I have been chipping away at a TypeScript rewrite of Koa as an exercise for myself. It seems there has been interest for some time within the koa 3.0 roadmap (#1114) for potentially pursuing this. If there is interest, then I'd be happy to work through trying to contribute this back. I am really just tidying things up at this point.

There are some implementation changes I made, which were predominantly to account for introducing typing as well as removal of code for supporting lesser versions of node around the _headers attribute. Also, I ported over the tests from mocha to jest. I tried to stick as close as possible to the original implementation and test suite as possible.

The repository can be found here: https://github.com/kubejm/koa-ts

If there is interest to contribute this, then let me know how you would like me to proceed as this is a rather significant change.

@dead-horse
Copy link
Member

Sorry, I don't see how rewriting with typescript is going to help us maintain koa. I don't think we will rewrite koa in typescript for now.

@wirekang
Copy link

@dead-horse I'm just curious why did you choose javascript over typescript.

@nook-scheel
Copy link

@dead-horse I'm just curious why did you choose javascript over typescript.

I'm more interested in what typescript will give?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants