Fix CI 馃悰 #28
Closed
Fix CI 馃悰 #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For example: |
|
@niftylettuce, I remember that we previously talked on Twitter that Windows is not a priority now .. so I will close this now and we will open it at another time ..... |
|
Cheers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @niftylettuce,
The last time I corrected all the tests, I was not aware of any differences in the expected result between all types of os. #16
I previously opened some pull requests in express/multer. During which I knew there was a bug inside the expected result .. Windows results differ on Linux and Mac.
please see #832, 181.
what do you think 馃 !!