Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix coverage with coveralls #30

Merged
merged 8 commits into from
May 27, 2020

Conversation

3imed-jaberi
Copy link
Member

  • add coverage config to integrate with coveralls and codecov (fix link to coveralls.io).
  • add me to contributors.
  • use async/await over then() > ES2017.
  • support node 8+ engine.

@niftylettuce , you can publish the next release and also add CHANGELOG file.

@niftylettuce niftylettuce merged commit 8cde5de into koajs:master May 27, 2020
@niftylettuce
Copy link
Contributor

@3imed-jaberi I merged this, but tests are failing right now:

  50 passing (1s)
  3 failing

  1) Disk Storage should process parser/form-data POST request:

      Uncaught AssertionError [ERR_ASSERTION]: 1778 == 1803
      + expected - actual

      -1778
      +1803

      at test/disk-storage.js:46:14
      at Immediate._onImmediate (test/_util.js:37:11)
      at processImmediate (internal/timers.js:458:21)

  2) Disk Storage should process multiple files:

      Uncaught AssertionError [ERR_ASSERTION]: 122 == 128
      + expected - actual

      -122
      +128

      at test/disk-storage.js:120:14
      at Immediate._onImmediate (test/_util.js:37:11)
      at processImmediate (internal/timers.js:458:21)

  3) Memory Storage should process multiple files:

      Uncaught AssertionError [ERR_ASSERTION]: 122 == 128
      + expected - actual

      -122
      +128

      at test/memory-storage.js:105:14
      at Immediate._onImmediate (test/_util.js:37:11)
      at processImmediate (internal/timers.js:458:21)



error Command failed with exit code 3.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

@3imed-jaberi
Copy link
Member Author

3imed-jaberi commented May 27, 2020

tests are failing right now

I was still making the test pass, you know the pb #28, i will open now new pr and make every thing work 100%

@3imed-jaberi 3imed-jaberi mentioned this pull request May 27, 2020
@niftylettuce
Copy link
Contributor

can you join our Slack channel for Lad?

https://lad.js.org -> there is a badge to join at top

@3imed-jaberi
Copy link
Member Author

can you join our Slack channel for Lad?

https://lad.js.org -> there is a badge to join at top

yes, I am coming

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants