-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix coverage with coveralls #30
Merged
niftylettuce
merged 8 commits into
koajs:master
from
3imed-jaberi:fix-coverage-with-coveralls
May 27, 2020
Merged
Fix coverage with coveralls #30
niftylettuce
merged 8 commits into
koajs:master
from
3imed-jaberi:fix-coverage-with-coveralls
May 27, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@3imed-jaberi I merged this, but tests are failing right now: 50 passing (1s)
3 failing
1) Disk Storage should process parser/form-data POST request:
Uncaught AssertionError [ERR_ASSERTION]: 1778 == 1803
+ expected - actual
-1778
+1803
at test/disk-storage.js:46:14
at Immediate._onImmediate (test/_util.js:37:11)
at processImmediate (internal/timers.js:458:21)
2) Disk Storage should process multiple files:
Uncaught AssertionError [ERR_ASSERTION]: 122 == 128
+ expected - actual
-122
+128
at test/disk-storage.js:120:14
at Immediate._onImmediate (test/_util.js:37:11)
at processImmediate (internal/timers.js:458:21)
3) Memory Storage should process multiple files:
Uncaught AssertionError [ERR_ASSERTION]: 122 == 128
+ expected - actual
-122
+128
at test/memory-storage.js:105:14
at Immediate._onImmediate (test/_util.js:37:11)
at processImmediate (internal/timers.js:458:21)
error Command failed with exit code 3.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command. |
I was still making the test pass, you know the pb #28, i will open now new pr and make every thing work 100% |
Merged
can you join our Slack channel for Lad? https://lad.js.org -> there is a badge to join at top |
yes, I am coming |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
coveralls
andcodecov
(fix link to coveralls.io).async/await
overthen()
> ES2017.