AssertionError: non-error thrown: false

[fengmk2]

assert.js:98
  throw new assert.AssertionError({
        ^
AssertionError: non-error thrown: false
    at Object.app.context.onerror (/Users/mk2/git/personalweb/node_modules/chair/node_modules/koa-onerror/index.js:50:5)
    at Socket.done (/Users/mk2/git/personalweb/node_modules/chair/node_modules/koa/node_modules/finished/index.js:15:5)
    at Socket.EventEmitter.emit (events.js:126:20)
    at TCP.close (net.js:467:12)

[fengmk2]

finished module:

module.exports = function (thingie, callback) {
  var socket = thingie.socket || thingie
  var res = thingie.res || thingie
  if (!socket.writable)
    return setImmediate(callback)

  socket.on('error', done)
  socket.on('close', done)
  res.on('finish', done)

  function done(err) {
    socket.removeListener('error', done)
    socket.removeListener('close', done)
    res.removeListener('finish', done)
    callback(err)
  }

  return thingie
}

[fengmk2]

https://github.com/joyent/node/blob/master/lib/net.js#L461

var isException = exception ? true : false;
    this._handle.close(function() {
      debug('emit close');
      self.emit('close', isException);
    });

[dead-horse]

err in callback(err) is false, not instance of Error?

[fengmk2]

when socket close event emit, err is a Boolean

[dead-horse]

hmmm. ping @jonathanong

[dead-horse]

i think it should fixed in finished

[fengmk2]

thingie.socket is ctx.socket, but why we need to listen error and close event?

[jonathanong]

Already fixed this in latest finished

[fengmk2]

same as jshttp/on-finished#1

close by jshttp/on-finished@8b2baaa

[fengmk2]

@jonathanong Also need to update koa deps: finished: '~1.1.3'

[jonathanong]

is that really necessary? semver can do the work