Fix select type replace aliases

[joshuaberetta]

Description

Fix bug that prevented select one being converted to select_one and handle legacy select one for exports and auto report to prevent failures.

Related issues

closes #250

[coveralls]

Coverage decreased (-0.6%) to 85.486% when pulling df2ad69 on 250-fix-select-type-replace-aliases into a2bbc81 on master.

[dorey]

Out of curiosity, I checked out master a2bbc81 and ran the tests with the select_one_legacy fixture and test and it passed in most scenarios.

The one scenario that didn't pass was when v1.json had

        "type": "select one",
        "select_from_list_name": "emperors",

Have we already fixed this in master? Or is the bug triggered by this particular scenario?

[dorey]

Also I made a smaller test to see if the internal representation of the FormPack object was correct:

    def test_select_one_legacy_choice_list_linked(self):
        title, schemas, submissions = build_fixture('select_one_legacy')
        fp = FormPack(schemas, title)
        section = fp[0].sections['Your favourite Roman emperors']
        choice_list = section.fields['fav_emperor'].choice.options
        opt1_label = choice_list['julius']['labels'][None]
        # if this passes, then the choice list is associated
        assert opt1_label == 'Julius Caesar'

[joshuaberetta]

@dorey sorry for letting this slip under the radar. Regarding this situation:

        "type": "select one",
        "select_from_list_name": "emperors",

This is the new buggy behaviour that I think my commit b98dbb1 introduced and this is on production. My fix here (as things stand) reverts back to the earlier behaviour of transforming this:

type	name	label
select one emperors	emperor	Who is your favourite emperor?

... into:

        "type": "select_one emperors",

When the now incorrect asset content contains:

        "type": "select one",
        "select_from_list_name": "emperors",

... the form-builder breaks that question and the export fails.

This fix at least allows for the export to succeed even if the form-builder complains about the still incorrect asset content:

If they upload their form again, the form-builder will function correctly as the new asset content is valid:

... and exports with all versions still works:

If they now changed their XLSForm to the preferred select_one:

type	name	label
select_one emperors	emperor	Who is your favourite emperor?

... the asset content looks good with:

        "type": "select_one",
        "select_from_list_name": "emperors",

... the form-builder still works as expected:

... and exports with all versions succeeds: