Remove deprecated legacy UI #885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… UserProfile model
…pi#4475-use-default-storage # Conflicts: # onadata/apps/main/views.py # onadata/libs/utils/export_tools.py
…box/kpi#4475-validate-password-flag
…pi#4475-use-default-storage
…box/kpi#4475-validate-password-flag
…pi#4475-use-default-storage
…box/kpi#4475-validate-password-flag
noliveleger
force-pushed
the
kobotoolbox/kpi#4475-shrink-kobocat
branch
from
e42b34b
to
f6f2459
Compare
…pi#4475-use-default-storage
…box/kpi#4475-validate-password-flag
JacquelineMorrissette
requested changes
Aug 15, 2023
…pi#4475-use-default-storage
…box/kpi#4475-validate-password-flag
…pi#4475-use-default-storage
…box/kpi#4475-validate-password-flag
…ault-storage Code refactoring: Use `default_storage` instead of `get_storage_class()()`
…e-password-flag Allow only OpenRosa endpoints with not-validated passwords
jnm
approved these changes
Aug 30, 2023
Comment on lines
16
to
20
| print("response['Location']", response['Location'], flush=True) | ||
| received, desired = ( | ||
| u.rstrip('/') for u in (response['Location'], settings.KOBOFORM_URL) | ||
| ) | ||
| assert received == desired |
There was a problem hiding this comment.
FYI @noliveleger, I removed print statements and added an assert, which seems correct and passes for me. LMK if it's wrong
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As announced on June 14, 2021, the legacy interface support has arrived to its end and has been removed.
Please use the regular interface instead.
Related issues
Blocked by #886