Allow only OpenRosa endpoints with not-validated passwords #887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…box/kpi#4475-validate-password-flag
7 tasks
…box/kpi#4475-validate-password-flag
…box/kpi#4475-validate-password-flag
noliveleger
force-pushed
the
kobotoolbox/kpi#4475-validate-password-flag
branch
from
99ac7c5
to
c0b2afd
Compare
…box/kpi#4475-validate-password-flag
noliveleger
force-pushed
the
kobotoolbox/kpi#4475-validate-password-flag
branch
from
a14a6b3
to
8224fd2
Compare
…box/kpi#4475-validate-password-flag
…box/kpi#4475-validate-password-flag
JacquelineMorrissette
requested changes
Aug 16, 2023
jnm
reviewed
Aug 29, 2023
| @@ -41,4 +41,4 @@ def process_view(self, request, view, args, kwargs): | |||
| if not is_logged_in and (view_name in REDIRECT_IF_NOT_LOGGED_IN): | |||
| return HttpResponseRedirect(login_url) | |||
|
|
|||
| pass | |||
| return | |||
There was a problem hiding this comment.
@noliveleger not that it's a blocker or anything, but is this explicitly needed for some reason?
There was a problem hiding this comment.
TBH, I really don't remember what I did that 😅 .
No it is absolutely not needed. Python does it for us behind the scene.
Comment on lines
+153
to
+157
| content_type, *_ = response.accepted_media_type.split(';') | ||
| except AttributeError: | ||
| pass | ||
| else: | ||
| *_, format_ = content_type.split('/') |
There was a problem hiding this comment.
I learned something new! 🎓
I think this way of considering only the first accepted_media_type isn't totally kosher, but it's fine for this purpose 👌
Base automatically changed from
kobotoolbox/kpi#4475-use-default-storage
to
kobotoolbox/kpi#4475-shrink-kobocat
August 30, 2023 01:57
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Superusers can flag accounts as not-validated password (i.e. password which don't respect password security rules).
These users can still collect data only until they reset their password and comply to password rules.
Related issues
Related to kobotoolbox/kpi#4475 and kobotoolbox/kpi#4473
Blocked by #886
Closes #881