Improve eslint switch statement handling #2228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and npm run script for linting
noliveleger
reviewed
Mar 21, 2019
| const choice = choices.find(x => x.list_name == q.select_from_list_name && x.name === submissionValue); | ||
| if (choice && choice.label && choice.label[translationIndex]) | ||
| return choice.label[translationIndex]; | ||
| else | ||
| return submissionValue; | ||
| break; | ||
| case 'select_multiple': | ||
| } | ||
| case 'select_multiple': { | ||
| var responses = submissionValue.split(' '); | ||
| var list = responses.map((r)=> { |
There was a problem hiding this comment.
According to the rules, you've described? Should this one be const list instead var list too?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The problem was that
casestatements without{}are "bad": https://stackoverflow.com/a/35746467/2311247I've added two new eslint rules to avoid this problem in the future :)
Related issues
Fixes #2227