Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop IE11 support #2718

Merged
merged 8 commits into from
Feb 14, 2022
Merged

Drop IE11 support #2718

merged 8 commits into from
Feb 14, 2022

Conversation

magicznyleszek
Copy link
Member

Description

Three things here:

  • Dropped IE11 from .browserslistrc (the file used for determining what browsers to support while building JS files)
  • Created a redirect to kf.kobo.local/modern_browsers/ with a message about modern browsers (I copied the message from Enketo)
  • Cleaned up some old IE-related things in templates

Related issues

Fixes #2716

# Conflicts:
#	kpi/templates/koboform.html
@magicznyleszek magicznyleszek changed the base branch from master to beta June 17, 2021 16:46
@magicznyleszek magicznyleszek requested review from duvld and removed request for jnm June 17, 2021 16:47
@magicznyleszek magicznyleszek assigned duvld and unassigned jnm Jun 17, 2021
@magicznyleszek magicznyleszek merged commit f70897e into beta Feb 14, 2022
@magicznyleszek magicznyleszek deleted the modern-browsers-message branch February 14, 2022 17:00
@magicznyleszek
Copy link
Member Author

There is not much hardcore changes here, so I allowed myself to merge it 😅

@jnm jnm mentioned this pull request Apr 26, 2022
p2edwards added a commit that referenced this pull request Mar 10, 2023
- Removed these packages:
  - @babel/core
  - @babel/polyfill
  - @babel/preset-env
  - @babel/preset-react
  - babel-eslint
  - babel-loader
  - eslint-webpack-plugin
  - less-terrible-coffeelint-loader

- Update browserslist data (npx browserslist@latest --update-db)

Note:

Although we dropped support for IE11 in #2718, it seems we've been
shipping an extra set of 'core-js' shims by importing @babel/polyfill
in main.es6.

The 'core-js' version already loaded by babel, or now swc, follows our
browserslist config. I'm removing the extra import since we've been
redirecting IE11 users to modern_browsers.html for a few years now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle Internet Explorer 11
3 participants