Update support and community URLs #2746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kobo/settings/base.py
Outdated
| 'URL for privacy policy'), | ||
| 'SOURCE_CODE_URL': ('https://github.com/kobotoolbox/', | ||
| 'URL of source code repository. When empty, a link ' | ||
| 'will not be shown in the user interface'), | ||
| 'SUPPORT_URL': (os.environ.get('KOBO_SUPPORT_URL', | ||
| 'http://help.kobotoolbox.org/'), | ||
| 'https://community.kobotoolbox.org/'), |
There was a problem hiding this comment.
Shouldn't SUPPORT_URL be http://support.kobotoolbox.org? And then add COMMUNITY_URL for https://community.kobotoolbox.org/ :)
There was a problem hiding this comment.
I chose what I did because help.kobotoolbox.org redirects to community.kobotoolbox.org ;)
@tinok, thoughts?
oops, as @magicznyleszek observes, SUPPORT_URL here isn't used yet but will be by #2747, and community.kobotoolbox.org is hard-coded. I'll change SUPPORT_URL to support… and add a new COMMUNITY_URL to this PR and ask for #2747 to be updated
|
@magicznyleszek, I'm giving you this PR 💝 |
jnm
changed the title
jnm
changed the title
magicznyleszek
approved these changes
Aug 5, 2020
|
Sounds good. I'll merge both of them in a moment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Quick & Easy 😉
Related issues
Closes #2722
Closes kobotoolbox/tasks#320