[ Row Level Access ] - Deployment back-end classes refactoring: Abstraction and variables renaming #3124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rtial permissions
…-refactoring # Conflicts: # kpi/deployment_backends/base_backend.py # kpi/deployment_backends/kobocat_backend.py # kpi/deployment_backends/mock_backend.py # kpi/views/v2/data.py
…-refactoring # Conflicts: # kpi/deployment_backends/kobocat_backend.py # kpi/deployment_backends/mock_backend.py
…-refactoring # Conflicts: # kpi/deployment_backends/base_backend.py # kpi/deployment_backends/kobocat_backend.py # kpi/deployment_backends/mock_backend.py
…-refactoring # Conflicts: # kpi/deployment_backends/base_backend.py # kpi/deployment_backends/kobocat_backend.py # kpi/deployment_backends/mock_backend.py # kpi/views/v2/data.py
…-refactoring # Conflicts: # kpi/deployment_backends/base_backend.py # kpi/deployment_backends/kobocat_backend.py # kpi/deployment_backends/mock_backend.py
BaseDeploymentBackend an abstractclass
noliveleger
changed the title
noliveleger
changed the title
jnm
requested changes
Jul 19, 2021
Base automatically changed from
3115-allowed-write-actions-with-partial-perm
to
2767-basic-case-management
July 26, 2021 18:46
jdugh
pushed a commit
to geohyd/kpi
that referenced
this pull request
Nov 21, 2022
[ Row Level Access ] - Deployment back-end classes refactoring: Abstraction and variables renaming
jdugh
pushed a commit
to geohyd/kpi
that referenced
this pull request
Nov 13, 2023
[ Row Level Access ] - Deployment back-end classes refactoring: Abstraction and variables renaming
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
While working on
MockDeploymentBackend,BaseDeploymentBackendandKobocatDeploymentBackend, I've noticed that I was not really consistent with variable names. This PR tries to bring more consistency in the code.The primary key of submissions
We have:
pksubmission_pksubmission_idinstance_idIt has been renamed
submission_ideverywhere (Hooktoo)Notes: KoBoCAT related branch
kpi-3115-row-level-write-permscontains some changes to support the new name for Rest ServicesThe requesting user
We have
user_iduser.pkrequesting_user_idrequesting_userMost of the time, we have access to the user object, we do not gain any performance (i.e.: any extra db queries) to pass PK only.
It has been renamed
userto be consistent with permissions.BaseDeploymentBackendIt has become an AbstractClass and defines methods which need to be implemented in children classes
Related issues
Related to #3115
Related to #2768