Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sync_kobocat_xform command #3278

Merged
merged 3 commits into from
Jun 14, 2021
Merged

Update sync_kobocat_xform command #3278

merged 3 commits into from
Jun 14, 2021

Conversation

joshuaberetta
Copy link
Member

Minor fix to #2675

Copy link
Contributor

@noliveleger noliveleger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot comment on the line I would like to, but I would remove the condition if username on line 583.
I would expect the media files to be synced when I called --sync-kobocat-form-media,
even if it's all files. Because it's false by default, if the user adds the option, we should assume they know what they are doing.
With the current behaviour, nothing happens if the username is not provided.
What do you think?

Morever, I think we should pass the verbosity to both sub commands populate_kc_xform_kpi_asset_uid and sync-kobocat-form-media.

@joshuaberetta
Copy link
Member Author

Those are good points 👍 I'll make the changes.

@noliveleger noliveleger merged commit fbe682a into beta Jun 14, 2021
@noliveleger noliveleger deleted the 2675-sync-form-media branch June 14, 2021 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants