Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix "different root names" Enketo error when editing a submission #4025

Merged
merged 2 commits into from
Sep 27, 2022
Merged

Fix "different root names" Enketo error when editing a submission #4025

merged 2 commits into from
Sep 27, 2022

Conversation

noliveleger
Copy link
Contributor

@noliveleger noliveleger commented Sep 20, 2022 •
edited
Loading

Checklist

  1. If you've added code that should be tested, add tests
  2. If you've changed APIs, update (or create!) the documentation
  3. Ensure the tests pass
  4. Make sure that your code lints and that you've followed our coding style
  5. Write a description of your work suitable for publishing on our forum
  6. Mention any related issues in this repository (as #ISSUE) and in other repositories (as kobotoolbox/other#ISSUE)
  7. Open an issue in the docs if there are UI/UX changes

Description

Always regenerate (and update the root of the <instance> node) of the XML of the form when editing a submission to match the submission root name.

Related issues

Closes #3996

@noliveleger noliveleger marked this pull request as ready for review September 20, 2022 19:57
jnm
jnm approved these changes Sep 27, 2022
View reviewed changes
Copy link
Member

@jnm jnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍾

@jnm jnm merged commit 26e6c5e into feature/nlp Sep 27, 2022
@jnm jnm deleted the 3996-different-root-names branch September 27, 2022 20:10
@jnm jnm mentioned this pull request Sep 27, 2022
Merged
7 tasks
@Kalyan-Lama
Copy link

Community: https://community.kobotoolbox.org/t/error-trying-to-parse-xml-record-different-root-nodes/33586

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnm jnm jnm approved these changes

Assignees

@jnm jnm

Labels
Back end bug-fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@noliveleger @Kalyan-Lama @jnm