Fix move to collection feature #4290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thus making it work again and fixing "Move to" functionality
|
Seems to work. The docker build failure is a timeout and seems unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
All user owned collection now will appear in more actions menu under "Move to" section.
Code review notes
This was introduced during router6 upgrade. Route changes and session changes turned out to be important for
ownedCollectionsStore:) I've added few comments to be more clear. I also found a good use forwhenfunction and I've updated few other components that should've been using it instead of wrongly usingobserver().Related issues
Fixes #4288