Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Storybook 7 #4503

Merged
merged 1 commit into from Jun 30, 2023
Merged

Upgrade to Storybook 7 #4503

merged 1 commit into from Jun 30, 2023

Conversation

bufke
Copy link
Contributor

@bufke bufke commented Jun 19, 2023

A (mostly) automated upgrade to storybook 7. I had to --force the package installs because reflux (and maybe others) creates impossible peer dependencies.

@p2edwards p2edwards self-assigned this Jun 29, 2023
Comment on lines +76 to +78
docs: {
autodocs: true
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the autodocs! They might need some work to get fully functional, though. KoboPrompt and KoboModal don't close and obscure the docs. KoboDropdown and KoboSelect also clip outside of the doc view's bounds when expanded, but the docs are still accessible and the story displays fine on the Primary tab so that's probably not worth spending much energy on.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A migration added this. I could go either way on it. Could disable it or just ignore the defects for now.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went back and forth about it, and I think the immediate benefit for frontend devs from having code examples outweighs having some wonky Storybook bits, so I'm approving. If you don't mind, could you create an issue/task to update the docs pages?

@bufke bufke merged commit a79a845 into beta Jun 30, 2023
4 checks passed
@p2edwards p2edwards mentioned this pull request Jul 5, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants