Redo package-lock #4526
Merged
Redo package-lock #4526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Recreate frontend package-lock file from an earlier version to fix build problems.
Details
A few divergent concurrent merges (#4387, #4503, #4520) resulted in frontend build failures from a package-lock.json.
This fix:
beta, using its package.jsonnpm install(with npm@8.5.5) to update the package-lock.json with any packages that were added or removed.Reviewer
It's a large diff, changing the lockfileVersion back from 3 to 2, compatible with npm@8.5.5, which we're still on until we can remove or change some dependencies.
Developers!
☝️ If your PR or feature branch has conflicts with package-lock.json after this change, please take the package-lock.json from upstream (use 'theirs') and run npm@8.5.5 to install your added/removed packages, then commit the updated lockfile.
Internal discussion: https://chat.kobotoolbox.org/#narrow/stream/4-Kobo-Dev/topic/Front-end.20building.20issues/near/245149
Checklist
Related issues
Related to #4366
Needed for #4505 (and active feature branches)