Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get Storybook compatible with TypeScript 5.x #4520

Merged
merged 2 commits into from Jun 30, 2023
Merged

Conversation

LMNTL
Copy link
Contributor

@LMNTL LMNTL commented Jun 29, 2023

Checklist

  1. If you've added code that should be tested, add tests
  2. If you've changed APIs, update (or create!) the documentation
  3. Ensure the tests pass
  4. Make sure that your code lints and that you've followed our coding style
  5. Write a description of your work suitable for publishing on our forum
  6. Mention any related issues in this repository (as #ISSUE) and in other repositories (as kobotoolbox/other#ISSUE)
  7. Open an issue in the docs if there are UI/UX changes

Description

Fixed a compatibility issue between Storybook and TypeScript 5.x.

Notes

Storybook doesn't play nice with TypeScript 5.x, and we just bumped our TS version. This is affecting the deploy:pages action on GitLab, as well as Storybook itself.

See this closed, unfixed issue on Storybook: storybookjs/storybook#21642

Fix (graciously) taken from here: hipstersmoothie/react-docgen-typescript-plugin#78

@LMNTL LMNTL changed the base branch from main to beta June 29, 2023 18:40
@LMNTL LMNTL marked this pull request as ready for review June 29, 2023 20:20
@bufke bufke merged commit 098dc0e into beta Jun 30, 2023
4 checks passed
@p2edwards p2edwards mentioned this pull request Jul 5, 2023
1 task
@LMNTL LMNTL deleted the bugfix/storybook-typescript-5 branch July 28, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants