Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalidated password screen #4530

Merged
merged 33 commits into from Aug 8, 2023
Merged

Invalidated password screen #4530

merged 33 commits into from Aug 8, 2023

Conversation

magicznyleszek
Copy link
Member

@magicznyleszek magicznyleszek commented Jul 6, 2023 •
edited

Description

Adds a screen to be presented to a user with an invalidated password. The screen provides some information and a way to update the password.

Notes

Front-end things that I've changed:

  • Fixed UpdatePasswordForm component to display multiple errors (instead of first one)
  • InvalidatedPassword component
    • displays some helpful text for the unfortunate user, and gives the option to update the password (using UpdatePasswordForm component)
    • it hooks into the App component - this way it blocks all the UI for all the routes, but still get the Router bonuses
  • AccountMenu component hides all navigation options for user with invalidated password
  • split MainHeader component into:
    • GitRev component that displays debug git information
    • MainHeaderBase component that includes only the layout (needed this becuse now we display the main header in two different places)
    • MainHeaderLogo component for easier reuse
    • MainHeader component is using the new parts
  • split ToasterConfig out of app.js, so I can reuse it :)

All Back-end code is already reviewed on other branches 👍

Related issues

Fixes #4477

magicznyleszek and others added 30 commits June 20, 2023 21:53
@magicznyleszek
Merge branch 'feature/password-complexity' into 4477-invalidated-pass…
3383d76 
…word-screen
@magicznyleszek
prepare files
d70a649
@magicznyleszek
Merge branch 'feature/password-complexity' into 4477-invalidated-pass…
ad61ba2 
…word-screen
@magicznyleszek
Show update password form on invalidated screen
edc2e91
@magicznyleszek
Merge branch 'feature/password-complexity' into 4477-invalidated-pass…
07d4255 
…word-screen
@magicznyleszek
Merge branch 'feature/password-complexity' into 4477-invalidated-pass…
9cbda67 
…word-screen

# Conflicts:
#	jsapp/js/router/allRoutes.es6
@magicznyleszek
add validated_password to TS interface and add comments
259f24c
@magicznyleszek
Merge branch 'feature/password-complexity' into 4477-invalidated-pass…
83d97d8 
…word-screen
@magicznyleszek
Merge remote-tracking branch 'origin/4473-track-password-changes' int…
7ec5b4e 
…o 4477-invalidated-password-screen
@noliveleger
Expose validate_password flag to /me endpoint
d05a284
@noliveleger
Split models in their own file
488886f
@noliveleger
Refactor admin models
c7f3d63
@noliveleger
Refactor admin models
1229b0d
@magicznyleszek
move validated_password inside extra_details
ab83ed5
@noliveleger
Register admin model to (in)validate passwords
800b7c9
@noliveleger
Use advanced search for password validation admin page
4ecbd11
@noliveleger
Do not display empty message when validator is turned off
a751731
@noliveleger
Merge branch '4477-invalidated-password-screen' of github.com:kobotoo…
ad3e2fe 
…lbox/kpi into 4477-invalidated-password-screen
@noliveleger
Merge branch '4477-invalidated-password-screen' into refactor-hub-app
e964e11
@magicznyleszek
move things back
7198197
@magicznyleszek
make UpdatePasswordForm displaying an array of errors (instead of one…
dc490e9 
… error)
@JacquelineMorrissette
Merge pull request #4565 from kobotoolbox:refactor-hub-app
a5033c1 
Refactor Django app `hub`
@JacquelineMorrissette
Merge pull request #4566 from kobotoolbox/4477-django-admin
5d82a24 
Add Django Admin section to handle password validation
@magicznyleszek
InvalidatedPasswordScreen styles
214ace6
@magicznyleszek
Merge branch '4477-invalidated-password-screen' of github.com:kobotoo…
10de86e 
…lbox/kpi into 4477-invalidated-password-screen
@magicznyleszek
hide form behind a button
64c1871
@magicznyleszek
Merge branch 'feature/password-complexity' into 4477-invalidated-pass…
b0b2046 
…word-screen
@magicznyleszek
style tweaks
d28e259
@noliveleger
Merge branch 'feature/password-complexity' into 4477-invalidated-pass…
619e44f 
…word-screen

 # Conflicts:
 #	hub/admin/extend_user.py
@noliveleger
Merge branch 'feature/password-complexity' into 4477-invalidated-pass…
fecfc1a 
…word-screen
@magicznyleszek magicznyleszek marked this pull request as ready for review August 7, 2023 22:36
@magicznyleszek magicznyleszek changed the title WIP Invalidated password screen Invalidated password screen Aug 7, 2023
@magicznyleszek magicznyleszek linked an issue Aug 8, 2023 that may be closed by this pull request
Invalidated password screen #4477
Closed
@LMNTL LMNTL self-requested a review August 8, 2023 13:59
@LMNTL LMNTL merged commit e5e655f into feature/password-complexity Aug 8, 2023
4 checks passed
@LMNTL LMNTL deleted the 4477-invalidated-password-screen branch August 8, 2023 19:01
@p2edwards p2edwards mentioned this pull request Oct 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LMNTL LMNTL LMNTL approved these changes

Assignees

@LMNTL LMNTL

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invalidated password screen
4 participants
@magicznyleszek @LMNTL @noliveleger @JacquelineMorrissette