Feature: TOS #4699
Merged
Feature: TOS #4699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and use it with InvalidatedPassword
# Conflicts: # jsapp/js/components/permissions/permValidator.es6 # jsapp/js/components/permissions/sharingForm.es6 # jsapp/js/utils.ts
- Add dropdown choices for organization_type - Add placeholder for email - Add organization_website to sign-up form - Make organization_website and organization_type removable from signup page via Constance USER_METADATA_FIELDS - Update 'Organization' label to 'Organization name' - Update CSS layout and field order to match designs
…reement-screen [TASK-111] Prepare TOS Agreement screen
# Conflicts: # jsapp/js/account/accountSettingsRoute.tsx
- TS dislikes {behavior: 'instant'}, suggests defaulting to auto
microsoft/TypeScript#46654 (comment)
- TS config abhors unused parameter
…from `KobocatDeploymentBackend` and `MockDeploymentBackend` into `BaseDeploymentBackend`
…backend-code Consolidate common deployment backend code
- infer 'http', not 'https', to reduce risk of broken links - allow and normalize single-slash and no-slash in protocol, e.g. http:/example.test, http:example.test => http://example.test/ - normalize trailing slash on URLs. e.g., https://example.test => https://example.test/ This is a biproduct of using built-in URL() method to normalize. If we don't want this, we could instead normalize protocol '://' with: value = value.replace( /(^https?)(:\/?\/?)(.*)/, (str,protocol,sep,rest) => protocol + '://' + rest );
For a succinct alternative: Mark the outline rule as !important;
…with an idea for achieving this with less JS and more CSS.
Improve appearance of Signup and User Profile fields
Keyboard-accessible Select component for TOS/Accounts
permission assignment to anonymous user
…and it otherwise looks quite weird. Improvements that could be made to this, but are not a priority at the moment: 1. Gridlike alignment of fields when there's long labels or error labels 2. Or put the field on its own row only when it shows an error
… The rest of the fields in the two-column layout have a submit-blocking frontend validation that is at least as strict as what the backend would reject, so the layout-shifting red error text is only relevant for email and username. (or extra long label translations. but the layout shifting is already slightly more optimized for that case.)
…mport Fix broken admin reports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a feature PR - it gathers reviewed and tested code in a single PR. We do smaller branches that are based in
feature/tosbranch.Description
Adds new fields to the signup and user profile settings, and a modal for existing users to confirm their acceptance of the Terms of Service and Privacy Policy.
Details
Overview of changes
Development notes
Related PR's
About 'Organization Type' skip logic
The 'Organization Type' field has a few different options, the last of which is "I am not associated with an organization". In the codebase, we call this
{ "organization_type": "none" }If the "Organization Type" is "none", then we don't need to collect a name and website. So we can hide these fields sometimes when they're not relevant. In the codebase, we call this "Skip logic", to match terminology of the same feature in Form Builder.)